########################################################################################## JILS-33: Issue Listings: DOM ID changes with every view ########################################################################################## Issue Type: Bug ----------------------------------------------------------------------------------------- Issue Information ==================== Priority: Major Status: Closed Resolution: Fixed (2016-04-29 14:58:52) Project: Jira Issue Listing Script (JILS) Reported By: btasker Assigned To: btasker Affected Versions: - 0.01b Targeted for fix in version: - 0.01b Time Estimate: 36 minutes Time Logged: 4 minutes ----------------------------------------------------------------------------------------- Issue Description ================== Commit b8cfd0f implemented Javascript based filtering and navigation on issue listing pages. In order to do so, the issue listing table needed to be given an ID, and the output of _mt\_rand_ was used to ensure the ID was unique if the table was ever called multiple times in one page. The downside of this, is that where the output of JILS is being used in an incremental backup, the pages change every time they're requested, regardless of whether there's been any activity on the project. Need to change to use a consistent ID. ----------------------------------------------------------------------------------------- Issue Relations ================ - blocks JILS-36: On Versions Pages Seperate Known Issues from Issue list - Commit b8cfd0f (Github) (https://github.com/bentasker/Jira-Issue-Listing/commit/b8cfd0f2da578aed9160b7f789869fec8bd6baf0) ----------------------------------------------------------------------------------------- Activity ========== ----------------------------------------------------------------------------------------- 2015-09-18 16:15:59 btasker ----------------------------------------------------------------------------------------- The table isn't currently called multiple times in any page, -- BEGIN SNIPPET -- # grep "issues-table" * component-issues.php: project-index.php: version-issues.php: -- END SNIPPET -- so moving to a static ID as a short-term fix should be a suitable method of stopping the issue with backups. Needs addressing properly longer term though. ----------------------------------------------------------------------------------------- 2015-09-18 16:16:03 ----------------------------------------------------------------------------------------- btasker changed status from 'Open' to 'In Progress' ----------------------------------------------------------------------------------------- 2015-09-18 16:17:56 btasker ----------------------------------------------------------------------------------------- Have set the id to be 1 for the time being. ----------------------------------------------------------------------------------------- 2015-09-18 16:18:15 ----------------------------------------------------------------------------------------- btasker changed timespent from '0 minutes' to '2 minutes' ----------------------------------------------------------------------------------------- 2015-09-18 16:18:56 git ----------------------------------------------------------------------------------------- -- BEGIN QUOTE -- Repo: Jira-Issue-Listing Commit: 5dcd22dae1c96ec21f9f229801d5bf58a3396fc6 Author: Ben Tasker