##########################################################################################

       MISC-9: Analytics/Social Icons show as enabled when Javascript is disabled

##########################################################################################


Issue Type: Bug 
-----------------------------------------------------------------------------------------

Issue Information
====================

Priority: Major					Status:      Closed
Resolution:  Fixed (2015-05-22 19:30:25)
Project: Miscellaneous (MISC)


Reported By: btasker					
Assigned To: btasker


Affected Versions:		
	- Bentasker.co.uk via Tor  			


Targeted for fix in version: 
	- Bentasker.co.uk via Tor


Time Estimate: 0 minutes
Time Logged:   0 minutes


-----------------------------------------------------------------------------------------

Issue Description
==================

Although they're obviously not triggering (because JS is disabled) the Privacy bar on the
left shows 'Enable Social Icons' and 'Enable Google Analytics' if Javascript isn't
enabled.

It's a minor thing, but probably worth changing the default text to represent the default
behaviour (or better remove the default text so that the bar only appears if JS is
enabled).

-----------------------------------------------------------------------------------------

Issue Relations
================
	
	- relates to MISC-6: Review 3rd party resources/code called from within the site


-----------------------------------------------------------------------------------------

Activity
==========

	
-----------------------------------------------------------------------------------------
2015-05-22 19:29:43              btasker
-----------------------------------------------------------------------------------------

Original block in template

-- BEGIN SNIPPET --

<h4>Privacy Options</h4>

</div>
<div class="tmplateOptions">
       	<a rel="nofollow" onclick="togglesocialIcons();" id='socialBlock'>Block Social
Icons</a>
</div>
<div class="tmplateOptions hidden-phone">
       	<a rel="nofollow" onclick="toggleGA();" id='GABlock'>Block Google Analytics</a>
</div>

<?php if (!$via_tor): ?>
       	<div class="tmplateOptions hidden-phone">
                <a rel="nofollow" href="<?php echo $onion_addr; ?>" id='OnionLink'>Browse
via Tor</a>
        </div>
<?php endif; ?>

 -- END SNIPPET --
Updated to

-- BEGIN SNIPPET --

<h4 id='privOpts'>Privacy Options</h4>
<div class="tmplateOptions">
       	<a rel="nofollow" onclick="togglesocialIcons();" id='socialBlock'></a>
</div>
<div class="tmplateOptions hidden-phone">
       	<a rel="nofollow" onclick="toggleGA();" id='GABlock'></a>
</div>

<?php if (!$via_tor): ?>
       	<div class="tmplateOptions hidden-phone">
                <a rel="nofollow" href="<?php echo $onion_addr; ?>" id='OnionLink'>Browse
via Tor</a>
        </div>
<?php endif; ?>

 -- END SNIPPET --
Re-tested with Orbot and the privacy bar no longer appears (which is fine as it requires
Javascript to work).
	
-----------------------------------------------------------------------------------------
2015-05-22 19:30:25              
-----------------------------------------------------------------------------------------

btasker changed status from 'Open' to 'Resolved'
	
-----------------------------------------------------------------------------------------
2015-05-22 19:30:25              
-----------------------------------------------------------------------------------------

btasker added 'Fixed' to resolution
	
-----------------------------------------------------------------------------------------
2015-05-22 19:30:30              
-----------------------------------------------------------------------------------------

btasker changed status from 'Resolved' to 'Closed'
	
-----------------------------------------------------------------------------------------
2015-05-22 19:51:58              btasker
-----------------------------------------------------------------------------------------

Note: Works fine in Lightning browser