##########################################################################################

       PAS-14: Tidy Up

##########################################################################################


Issue Type: Task 
-----------------------------------------------------------------------------------------

Issue Information
====================

Priority: Major					Status:      Open
Resolution:  Unresolved
Project: PCAP Analysis Script (PAS)


Reported By: btasker					
Assigned To: btasker


Affected Versions:		
	- 0.1  			


Targeted for fix in version: 
	- 0.1


Time Estimate: 29 minutes
Time Logged:   1 minutes


-----------------------------------------------------------------------------------------

Issue Description
==================

The structure of the current codebase is pretty much brain vomit, it needs a good tidy.

Also a good opportunity to make sure comments are present, accurate and relevant.

-----------------------------------------------------------------------------------------

Activity
==========

	
-----------------------------------------------------------------------------------------
2015-11-26 13:19:12              
-----------------------------------------------------------------------------------------

btasker changed timespent from '0 minutes' to '1 minutes'
	
-----------------------------------------------------------------------------------------
2015-11-26 13:19:48              git
-----------------------------------------------------------------------------------------


-- BEGIN QUOTE --


Repo: PCAPAnalyseandReport
Commit: 17130f2a73390bcde3304c6bed409e9b6cdbb99d
Author: Ben Tasker <github@<Domain Hidden>>

Date: Thu Nov 26 13:18:36 2015 +0000
Commit Message: Removing commented out statements and tidying whitespace a bit. PAS-14



Modified (-)(+)
-------
PCAP_Analysis.sh



-- END QUOTE --

*Webhook User-Agent*


-- BEGIN SNIPPET --

GitHub-Hookshot/333881f
 -- END SNIPPET --

https://github.com/bentasker/PCAPAnalyseandReport/commit/17130f2a73390bcde3304c6bed409e9b6cdbb99d


	
-----------------------------------------------------------------------------------------
2015-11-27 13:41:38              btasker
-----------------------------------------------------------------------------------------

As part of the tidy up, I also want to replace all instances of

-- BEGIN SNIPPET --

awk -F'	     ' 

 -- END SNIPPET --
with

-- BEGIN SNIPPET --

awk -F '\t' 

 -- END SNIPPET --
The former is quicker and easier to type (which is why I've been using it), but leaves too
much room for mistakes (copying and pasting between editors might convert to spaces, for
example). The latter is also easier to see for what it is in any format that doesn't have
syntax highlighting
	
-----------------------------------------------------------------------------------------
2015-11-27 14:18:31              btasker
-----------------------------------------------------------------------------------------

I've tidied up the stdout output a bit, and made things a bit more verbose:

-- BEGIN SNIPPET --

Starting, using /tmp/pcapanalysis.27514 for temp files
Processing PCAP
	Extracting a list of Destination Ports
	Analysing Port 80 Traffic
	Analysing SSL/TLS traffic
	Extracting Mail related traffic
Correlating information
	Identifying HTTPS pages from HTTP Referrers
	Looking for interesting referers
	Looking for interesting paths
	Looking for XMPP traffic
Building reports
	Processing webtraffic.csv
	Building list of known IPs
	Building cookie list
	Building User-agent list
	Building FQDN list
	Building Credential List
	Building list of httpspaths - httpspaths.csv
	Building IP/Port list - dest-ip-ports.csv 
	Creating interesting URLs list 
	Extracting interesting cookies
	Building xmpppeers.csv
	Building mailtransactions.csv
Done- Reports in report.example-split.pcap3.1448633576

 -- END SNIPPET --
	
-----------------------------------------------------------------------------------------
2015-11-27 14:19:44              git
-----------------------------------------------------------------------------------------


-- BEGIN QUOTE --


Repo: PCAPAnalyseandReport
Commit: c8d4567af78a9e721572a8f3f4ec3d8811b1a61b
Author: Ben Tasker <github@<Domain Hidden>>

Date: Fri Nov 27 14:17:36 2015 +0000
Commit Message: Tidied up script output a bit. See PAS-14



Modified (-)(+)
-------
PCAP_Analysis.sh



-- END QUOTE --

*Webhook User-Agent*


-- BEGIN SNIPPET --

GitHub-Hookshot/333881f
 -- END SNIPPET --

https://github.com/bentasker/PCAPAnalyseandReport/commit/c8d4567af78a9e721572a8f3f4ec3d8811b1a61b


	
-----------------------------------------------------------------------------------------
2016-02-03 13:34:23              btasker
-----------------------------------------------------------------------------------------

There are a few more commented out sections (mostly disabled in PAS-19) which can now be
removed.

I've stripped out the literal tabs and replaced with "\t". Test run going at the moment.
	
-----------------------------------------------------------------------------------------
2016-02-03 13:47:32              git
-----------------------------------------------------------------------------------------


-- BEGIN QUOTE --


Repo: PCAPAnalyseandReport
Commit: a2a4dd6e8b3f375bff5b7ca2f7153ae5ed300346
Author: Ben Tasker <github@<Domain Hidden>>

Date: Wed Feb 03 13:34:32 2016 +0000
Commit Message: Swapping out literal tabs for PAS-14



Modified (-)(+)
-------
PCAP_Analysis.sh



-- END QUOTE --

*Webhook User-Agent*


-- BEGIN SNIPPET --

GitHub-Hookshot/21f57ba
 -- END SNIPPET --

https://github.com/bentasker/PCAPAnalyseandReport/commit/a2a4dd6e8b3f375bff5b7ca2f7153ae5ed300346


	
-----------------------------------------------------------------------------------------
2016-02-03 13:47:33              git
-----------------------------------------------------------------------------------------


-- BEGIN QUOTE --


Repo: PCAPAnalyseandReport
Commit: a802298404c0c198adc1e6cec5ca264eab00fd74
Author: Ben Tasker <github@<Domain Hidden>>

Date: Wed Feb 03 13:35:42 2016 +0000
Commit Message: Removing obsoleted lines. See PAS-14



Modified (-)(+)
-------
PCAP_Analysis.sh



-- END QUOTE --

*Webhook User-Agent*


-- BEGIN SNIPPET --

GitHub-Hookshot/21f57ba
 -- END SNIPPET --

https://github.com/bentasker/PCAPAnalyseandReport/commit/a802298404c0c198adc1e6cec5ca264eab00fd74




-----------------------------------------------------------------------------------------

Worklog
========

 
-----------------------------------------------------------------------------------------
2015-11-26 13:19:11              btasker

1 minutes
-----------------------------------------------------------------------------------------

Removing commented out sections and tidying whitespace a little