##########################################################################################

       PHPCRED-25: Keylength calculation incorrect

##########################################################################################


Issue Type: Task 
-----------------------------------------------------------------------------------------

Issue Information
====================

Priority: Major					Status:      Resolved
Resolution:  Done (2014-07-25 02:31:49)
Project: PHPCredlocker (PHPCRED)


Reported By: btasker					
Assigned To: btasker

Components: 
	- Crypto 

Affected Versions:		
	- 1.15  			
	- 1.5  			
	- 1.25  			


Targeted for fix in version: 
	- 1.25


Time Estimate: 0 minutes
Time Logged:   0 minutes


-----------------------------------------------------------------------------------------

Issue Description
==================

The keylength calculation made in Crypto::xorestring(), Crypto::xordstring(), xorestr(),
xordstr() is incorrect.

The length needs to be calculated against one of the segments as the current calculation
allows the crypto to fall off the end of the key (resulting either in errors, or values of
0 being used in the Xor - depending on the implementation).

Issue was identified and fixed in the BTFW fork ( BTFW-7 )

-----------------------------------------------------------------------------------------

Activity
==========

	
-----------------------------------------------------------------------------------------
2014-07-25 02:31:40              btasker
-----------------------------------------------------------------------------------------

Resolved by commit 4ca4abd
	
-----------------------------------------------------------------------------------------
2014-07-25 02:31:49              
-----------------------------------------------------------------------------------------

btasker changed status from 'Open' to 'Resolved'
	
-----------------------------------------------------------------------------------------
2014-07-25 02:31:49              
-----------------------------------------------------------------------------------------

btasker added 'Done' to resolution