##########################################################################################

       GPXIN-13: If Speed is unavailable, calculate Time Moving based on lat lon changes

##########################################################################################


Issue Type: New Feature 
-----------------------------------------------------------------------------------------

Issue Information
====================

Priority: Minor					Status:      Closed
Resolution:  Done (2015-08-13 17:59:01)
Project: PHP GPXIngest (GPXIN)


Reported By: btasker					
Assigned To: btasker


Affected Versions:		
	- 1.02  			


Targeted for fix in version: 
	- 1.02


Time Estimate: 0 minutes
Time Logged:   0 minutes


-----------------------------------------------------------------------------------------

Issue Description
==================

If trackpoints do not include speed values, calculate the time moving stats (implemented
in GPXIN-7) based on whether the lat/lon values have changed between trackpoints.

-----------------------------------------------------------------------------------------

Issue Relations
================
	
	- relates to GPXIN-7: Time Moving Stats


-----------------------------------------------------------------------------------------

Activity
==========

	
-----------------------------------------------------------------------------------------
2015-01-14 23:03:21              
-----------------------------------------------------------------------------------------

btasker changed priority from '[issuelistpty 3]Major[/issuelistpty]' to '[issuelistpty
4]Minor[/issuelistpty]'
	
-----------------------------------------------------------------------------------------
2015-08-09 00:51:03              btasker
-----------------------------------------------------------------------------------------

If distance calculations are enabled (GPXIN-13) then the speed should be calculated once
the time between trackpoints has been calculated
	
-----------------------------------------------------------------------------------------
2015-08-10 13:52:06              git
-----------------------------------------------------------------------------------------


-- BEGIN QUOTE --


Repo: PHP-GPX-Ingest
Commit: 05af1e87f7e1c32735e0715f571be8e068544b29
Author: Ben Tasker <github@<Domain Hidden>>

Date: Mon Aug 10 13:50:56 2015 +0100
Commit Message: Class will calculate speed and timemoving from calculateddistance if
enabled. Minor issues. See GPXIN-13



Modified (-)(+)
-------
GPXIngest.class.php



-- END QUOTE --

*Webhook User-Agent*


-- BEGIN SNIPPET --

GitHub-Hookshot/29237e4
 -- END SNIPPET --

https://github.com/bentasker/PHP-GPX-Ingest/commit/05af1e87f7e1c32735e0715f571be8e068544b29


	
-----------------------------------------------------------------------------------------
2015-08-10 14:01:25              btasker
-----------------------------------------------------------------------------------------

Commit _05af1e8_ implements the basic functionality and the output appears correct

-- BEGIN SNIPPET --

<?php
require 'GPXIngest.class.php';

$gpx = new GPXIngest();
$gpx->enableExperimental('calcDistance');
$gpx->loadFile('test.gpx');
$gpx->ingest();
echo $json = $gpx->getJSON();

 -- END SNIPPET --
However, the class is generating PHP warnings (repeatedly)

-- BEGIN SNIPPET --

PHP Warning:  array_count_values(): Can only count STRING and INTEGER values! in
/tmp/gpx/GPXIngest.class.php on line 701
PHP Warning:  array_count_values(): Can only count STRING and INTEGER values! in
/tmp/gpx/GPXIngest.class.php on line 776
PHP Warning:  array_count_values(): Can only count STRING and INTEGER values! in
/tmp/gpx/GPXIngest.class.php on line 475

 -- END SNIPPET --

All relate to trying to extract the modal speed

-- BEGIN SNIPPET --

475: 		$modesearch = array_count_values($this->journeyspeeds);
701: 		$modesearch = array_count_values($this->sspeed);
776: 		$modesearch = array_count_values($this->fspeed);

 -- END SNIPPET --
I'd guess we're occasionally setting a boolean as speedint which is then pushed into
_fspeed_ and _sspeed_ on line _427_

-- BEGIN SNIPPET --

$this->fspeed[] = $ptspeed;
$this->sspeed[] = $ptspeed;

 -- END SNIPPET --
Should be reasonably easy to sort out, but well worth double-checking where else _ptspeed_
is used.
	
-----------------------------------------------------------------------------------------
2015-08-10 14:08:40              btasker
-----------------------------------------------------------------------------------------

Dropped a debug statement in

-- BEGIN SNIPPET --

echo "Speedstring: $speed_string (".gettype($speed_string)."), ".
"speedint: $ptspeed (".gettype($ptspeed)."),".
"dist: $dist, entryperiod: {$this->entryperiod}\n";

 -- END SNIPPET --
Looks like we're occasionally getting a double

-- BEGIN SNIPPET --

Speedstring: 0 MPH (string), speedint: 0 (integer),dist: 0, entryperiod: 0
Speedstring: 1 MPH (string), speedint: 1 (double),dist: 12.54, entryperiod: 11
Speedstring: 1 MPH (string), speedint: 1 (double),dist: 35.688, entryperiod: 17
Speedstring: 2 MPH (string), speedint: 2 (double),dist: 165.323, entryperiod: 57
Speedstring: 2 MPH (string), speedint: 2 (double),dist: 58.918, entryperiod: 17
Speedstring: 2 MPH (string), speedint: 2 (double),dist: 51.325, entryperiod: 20
Speedstring: 1 MPH (string), speedint: 1 (double),dist: 14.79, entryperiod: 16
Speedstring: 2 MPH (string), speedint: 2 (double),dist: 29.621, entryperiod: 13
Speedstring: 1 MPH (string), speedint: 1 (double),dist: 14.438, entryperiod: 12
PHP Warning:  array_count_values(): Can only count STRING and INTEGER values! in
/tmp/gpx/GPXIngest.class.php on line 703
PHP Warning:  array_count_values(): Can only count STRING and INTEGER values! in
/tmp/gpx/GPXIngest.class.php on line 703
PHP Warning:  array_count_values(): Can only count STRING and INTEGER values! in
/tmp/gpx/GPXIngest.class.php on line 703
PHP Warning:  array_count_values(): Can only count STRING and INTEGER values! in
/tmp/gpx/GPXIngest.class.php on line 703
PHP Warning:  array_count_values(): Can only count STRING and INTEGER values! in
/tmp/gpx/GPXIngest.class.php on line 703
PHP Warning:  array_count_values(): Can only count STRING and INTEGER values! in
/tmp/gpx/GPXIngest.class.php on line 703
PHP Warning:  array_count_values(): Can only count STRING and INTEGER values! in
/tmp/gpx/GPXIngest.class.php on line 703
PHP Warning:  array_count_values(): Can only count STRING and INTEGER values! in
/tmp/gpx/GPXIngest.class.php on line 703

 -- END SNIPPET --
So commit _f6106ed_ castes _ptspeed_ to an integer
	
-----------------------------------------------------------------------------------------
2015-08-10 14:09:59              btasker
-----------------------------------------------------------------------------------------

It's probably wise (for debugging purposes) to add some sort of metadata to note that the
speed was auto-calculated.
	
-----------------------------------------------------------------------------------------
2015-08-10 14:10:06              git
-----------------------------------------------------------------------------------------


-- BEGIN QUOTE --


Repo: PHP-GPX-Ingest
Commit: f6106edfdd4ea47bc3811f52e22f2bca4c7a16af
Author: Ben Tasker <github@<Domain Hidden>>

Date: Mon Aug 10 14:08:18 2015 +0100
Commit Message: Ensured calculated ptspeed is an integer. See GPXIN-13



Modified (-)(+)
-------
GPXIngest.class.php



-- END QUOTE --

*Webhook User-Agent*


-- BEGIN SNIPPET --

GitHub-Hookshot/29237e4
 -- END SNIPPET --

https://github.com/bentasker/PHP-GPX-Ingest/commit/f6106edfdd4ea47bc3811f52e22f2bca4c7a16af


	
-----------------------------------------------------------------------------------------
2015-08-10 14:15:47              btasker
-----------------------------------------------------------------------------------------

Created a new array within the metadata object - _AutoCalc_ - if the speed has been
calculated from the distance calculations it will set _speed_ to true. Used an array so
that if we end up calculating other items in future we don't flood the metadata object
with near identical properties.
	
-----------------------------------------------------------------------------------------
2015-08-10 14:16:06              git
-----------------------------------------------------------------------------------------


-- BEGIN QUOTE --


Repo: PHP-GPX-Ingest
Commit: 8ee01e694a5b4cecd4b60173a225f338dd6d5e54
Author: Ben Tasker <github@<Domain Hidden>>

Date: Mon Aug 10 14:14:29 2015 +0100
Commit Message: Updated metadata to reflect whether speed has been auto-calculated. See
GPXIN-13



Modified (-)(+)
-------
GPXIngest.class.php



-- END QUOTE --

*Webhook User-Agent*


-- BEGIN SNIPPET --

GitHub-Hookshot/29237e4
 -- END SNIPPET --

https://github.com/bentasker/PHP-GPX-Ingest/commit/8ee01e694a5b4cecd4b60173a225f338dd6d5e54


	
-----------------------------------------------------------------------------------------
2015-08-13 17:59:01              
-----------------------------------------------------------------------------------------

btasker changed status from 'Open' to 'Resolved'
	
-----------------------------------------------------------------------------------------
2015-08-13 17:59:01              
-----------------------------------------------------------------------------------------

btasker added 'Done' to resolution
	
-----------------------------------------------------------------------------------------
2015-08-13 17:59:08              
-----------------------------------------------------------------------------------------

btasker changed status from 'Resolved' to 'Closed'
	
-----------------------------------------------------------------------------------------
2015-08-13 18:00:10              btasker
-----------------------------------------------------------------------------------------

Have marked as Complete - currently this will only happen if Distance calculations are
explicitly enabled - the longer term plan though is to remove the need for explicit
enabling of that functionality.