##########################################################################################

       GPXIN-25: Multiple Track Support not Working

##########################################################################################


Issue Type: Bug 
-----------------------------------------------------------------------------------------

Issue Information
====================

Priority: Major					Status:      Closed
Resolution:  Fixed (2016-02-13 11:55:04)
Project: PHP GPXIngest (GPXIN)


Reported By: btasker					
Assigned To: btasker


Affected Versions:		
	- 1.02  			


Targeted for fix in version: 
	- 1.02


Time Estimate: 10 minutes
Time Logged:   10 minutes


-----------------------------------------------------------------------------------------

Issue Description
==================

Reported in Github #5


-- BEGIN QUOTE --

i have file with many trk in one gpx-file...

but your script work only with LAST trk-section in xml...

you could introduce support for these files?

thanks

-- END QUOTE --

-----------------------------------------------------------------------------------------

Attachments
============

	- 20130518.gpx.zip


-----------------------------------------------------------------------------------------

Issue Relations
================
	
	- Github #5 (https://github.com/bentasker/PHP-GPX-Ingest/issues/5)



-----------------------------------------------------------------------------------------

Activity
==========

	
-----------------------------------------------------------------------------------------
2016-02-13 10:57:08              btasker
-----------------------------------------------------------------------------------------

Nice catch - that's a bug.

The script is supposed to support multiple tracks, however, whilst it iterates over them
it fails to increase the numeric key used for that track (or within the codebase -
journey) and so essentially overwrites the previously processed tracks.

Variable is defined here -
https://github.com/bentasker/PHP-GPX-Ingest/blob/master/GPXIngest.class.php#L232
Used here -
https://github.com/bentasker/PHP-GPX-Ingest/blob/master/GPXIngest.class.php#L243

But never incremented
	
-----------------------------------------------------------------------------------------
2016-02-13 10:57:21              btasker
-----------------------------------------------------------------------------------------

Attaching provided example GPX
	
-----------------------------------------------------------------------------------------
2016-02-13 10:57:21              
-----------------------------------------------------------------------------------------

btasker added '20130518.gpx.zip' to Attachments
	
-----------------------------------------------------------------------------------------
2016-02-13 11:00:04              
-----------------------------------------------------------------------------------------

btasker changed timespent from '0 minutes' to '5 minutes'
	
-----------------------------------------------------------------------------------------
2016-02-13 11:00:52              btasker
-----------------------------------------------------------------------------------------

Have just committed a fix. It's possible it'll interfere with the overall file stats,
though it doesn't read as though it should.

Should also look at renaming the variable to something more meaningful
	
-----------------------------------------------------------------------------------------
2016-02-13 11:01:27              git
-----------------------------------------------------------------------------------------


-- BEGIN QUOTE --


Repo: PHP-GPX-Ingest
Commit: 51efb6a76bcfb48c48efec26a649029f333c90ea
Author: B Tasker <github@<Domain Hidden>>

Date: Sat Feb 13 10:59:39 2016 +0000
Commit Message: Fixed track counter. See GPXIN-25 and #5



Modified (-)(+)
-------
GPXIngest.class.php



-- END QUOTE --

*Webhook User-Agent*


-- BEGIN SNIPPET --

GitHub-Hookshot/21f57ba
 -- END SNIPPET --

https://github.com/bentasker/PHP-GPX-Ingest/commit/51efb6a76bcfb48c48efec26a649029f333c90ea


	
-----------------------------------------------------------------------------------------
2016-02-13 11:03:27              git
-----------------------------------------------------------------------------------------


-- BEGIN QUOTE --


Repo: PHP-GPX-Ingest
Commit: f8a5bd88efcb30fbd0f457de5ab284b213bfc133
Author: B Tasker <github@<Domain Hidden>>

Date: Sat Feb 13 11:02:37 2016 +0000
Commit Message: Renaming trackcounter variable to something more meaningful. See GPXIN-25



Modified (-)(+)
-------
GPXIngest.class.php



-- END QUOTE --

*Webhook User-Agent*


-- BEGIN SNIPPET --

GitHub-Hookshot/21f57ba
 -- END SNIPPET --

https://github.com/bentasker/PHP-GPX-Ingest/commit/f8a5bd88efcb30fbd0f457de5ab284b213bfc133


	
-----------------------------------------------------------------------------------------
2016-02-13 11:49:27              git
-----------------------------------------------------------------------------------------


-- BEGIN QUOTE --


Repo: PHP-GPX-Ingest
Commit: 82df9205d80901bdba3554c92ca921f3de9cc4fa
Author: B Tasker <github@<Domain Hidden>>

Date: Sat Feb 13 11:48:51 2016 +0000
Commit Message: Correcting missed variable name change. See GPXIN-25



Modified (-)(+)
-------
GPXIngest.class.php



-- END QUOTE --

*Webhook User-Agent*


-- BEGIN SNIPPET --

GitHub-Hookshot/21f57ba
 -- END SNIPPET --

https://github.com/bentasker/PHP-GPX-Ingest/commit/82df9205d80901bdba3554c92ca921f3de9cc4fa


	
-----------------------------------------------------------------------------------------
2016-02-13 11:52:17              btasker
-----------------------------------------------------------------------------------------

Commit  f8a5bd8 had an error - I missed renaming one instance of a, so all journey names
were being set to "journey" leading to the same behaviour as previously. Commit 82df920
fixes

-- BEGIN SNIPPET --

~# cat test.php
<?php
include 'GPXIngest.class.php';
$gpx = new GPXIngest();
$gpx->loadFile('20130518.gpx');
$gpx->ingest();

print_r($gpx->getTrackIDs());
~# php test.php
Array
(
    [0] => journey0
    [1] => journey1
    [2] => journey2
    [3] => journey3
    [4] => journey4
    [5] => journey5
    [6] => journey6
    [7] => journey7
    [8] => journey8
    [9] => journey9
    [10] => journey10
    [11] => journey11
    [12] => journey12
    [13] => journey13
    [14] => journey14
    [15] => journey15
)

 -- END SNIPPET --
	
-----------------------------------------------------------------------------------------
2016-02-13 11:54:02              
-----------------------------------------------------------------------------------------

btasker changed timespent from '5 minutes' to '10 minutes'
	
-----------------------------------------------------------------------------------------
2016-02-13 11:55:04              btasker
-----------------------------------------------------------------------------------------

User reports it's working as expected now. Closing as Fixed
	
-----------------------------------------------------------------------------------------
2016-02-13 11:55:04              
-----------------------------------------------------------------------------------------

btasker changed status from 'Open' to 'Resolved'
	
-----------------------------------------------------------------------------------------
2016-02-13 11:55:04              
-----------------------------------------------------------------------------------------

btasker added 'Fixed' to resolution
	
-----------------------------------------------------------------------------------------
2016-02-13 11:55:10              
-----------------------------------------------------------------------------------------

btasker changed status from 'Resolved' to 'Closed'


-----------------------------------------------------------------------------------------

Worklog
========

 
-----------------------------------------------------------------------------------------
2016-02-13 11:00:03              btasker

5 minutes
-----------------------------------------------------------------------------------------

Fixing
 
-----------------------------------------------------------------------------------------
2016-02-13 11:54:02              btasker

5 minutes
-----------------------------------------------------------------------------------------

Testing previous fix and correcting