##########################################################################################

       GPXIN-34: Normalise attribute names

##########################################################################################


Issue Type: New Feature 
-----------------------------------------------------------------------------------------

Issue Information
====================

Priority: Major					Status:      Closed
Resolution:  Done (2017-07-04 12:19:11)
Project: PHP GPXIngest (GPXIN)


Reported By: btasker					
Assigned To: btasker



Targeted for fix in version: 
	- 1.03


Time Estimate: 24 minutes
Time Logged:   21 minutes


-----------------------------------------------------------------------------------------

Issue Description
==================

As pointed out in Github #19 there's some inconsistency in attribute naming between routes
and tracks.

In tracks we use "elevation" whereas in waypoint types we use "ele".

Need to look at making this consistent

-----------------------------------------------------------------------------------------

Issue Relations
================
	
	- Github #19 (https://github.com/bentasker/PHP-GPX-Ingest/issues/19)

	- Documentation (bentasker.co.uk) (https://www.bentasker.co.uk/documentation/development-programming/222-php-gpx-ingest?#objectsextract)



-----------------------------------------------------------------------------------------

Activity
==========

	
-----------------------------------------------------------------------------------------
2017-07-04 10:18:05              btasker
-----------------------------------------------------------------------------------------

I agree with the observation in #19 that as we have "lat" and "lon", "ele" probably makes
more sense. 

However, "elevation" has been used in tracks for quite some time, so simply changing it
would break backwards-compatability (no matter how limited the size of the user base). So
need to take that into account too.
	
-----------------------------------------------------------------------------------------
2017-07-04 10:29:30              git
-----------------------------------------------------------------------------------------


-- BEGIN QUOTE --


Repo: PHP-GPX-Ingest
Commit: af54adae36e8d24f6962919046ba22e6e9e67b37
Author: B Tasker <github@<Domain Hidden>>

Date: Tue Jul 04 10:27:19 2017 +0100
Commit Message: GPXIN-34 - Normalise elevation attribute name in trackpoints to "ele"

To avoid break b/c, "elevation" remains valid but should be considered deprecated and
*will* be removed at some point.

In a GPX file with 2100 trackpoints, having both set makes the serialised JSON
approximately 8K larger.



Modified (-)(+)
-------
src/GPXIngest/GPXIngest.php



-- END QUOTE --

*Webhook User-Agent*


-- BEGIN SNIPPET --

GitHub-Hookshot/18889e1
 -- END SNIPPET --

https://github.com/bentasker/PHP-GPX-Ingest/commit/af54adae36e8d24f6962919046ba22e6e9e67b37


	
-----------------------------------------------------------------------------------------
2017-07-04 10:36:52              btasker
-----------------------------------------------------------------------------------------

Although the documentation is behind in plenty of other ways, I've updated it to refer to
"ele" instead of "elevation" (and added a note to explain the latter is deprecated) so
that if anyone does follow it they don't wind up using the older attribute.
	
-----------------------------------------------------------------------------------------
2017-07-04 10:37:44              
-----------------------------------------------------------------------------------------

btasker changed timespent from '0 minutes' to '21 minutes'
	
-----------------------------------------------------------------------------------------
2017-07-04 12:19:06              btasker
-----------------------------------------------------------------------------------------

I think the main attributes are now all normalised:

- lat
- lon
- ele

So marking this as complete for now. Will raise a new issue if I find any I've missed.
	
-----------------------------------------------------------------------------------------
2017-07-04 12:19:11              
-----------------------------------------------------------------------------------------

btasker changed status from 'Open' to 'Resolved'
	
-----------------------------------------------------------------------------------------
2017-07-04 12:19:11              
-----------------------------------------------------------------------------------------

btasker added 'Done' to resolution
	
-----------------------------------------------------------------------------------------
2017-07-04 12:19:15              
-----------------------------------------------------------------------------------------

btasker changed status from 'Resolved' to 'Closed'


-----------------------------------------------------------------------------------------

Worklog
========

 
-----------------------------------------------------------------------------------------
2017-07-04 10:37:43              btasker

21 minutes
-----------------------------------------------------------------------------------------

Adding "ele" attribute to trackpoints, testing and updating docs