########################################################################################## HLS-10: When parrallelised transcodes finish, the bitrate for the last isn't output ########################################################################################## Issue Type: Bug ----------------------------------------------------------------------------------------- Issue Information ==================== Priority: Trivial Status: Closed Resolution: Fixed (2016-05-18 07:56:17) Project: HLS Stream Creator (HLS) Reported By: btasker Assigned To: btasker Components: - Transcoding Affected Versions: - 1.0 Targeted for fix in version: - 1.0 Time Estimate: 0 minutes Time Logged: 41 minutes ----------------------------------------------------------------------------------------- Issue Description ================== When multiple transcodes are run at once, the monitor outputs when a bitrate finishes it's transcode process. Expected output is -- BEGIN SNIPPET -- ffmpeg command found.... continuing Generating HLS segments for bitrate 28k - this may take some time Generating HLS segments for bitrate 36k - this may take some time All transcoding processes started, awaiting completion Encoding for bitrate 28k completed Encoding for bitrate 36k completed -- END SNIPPET -- Actual output is -- BEGIN SNIPPET -- ffmpeg command found.... continuing Generating HLS segments for bitrate 28k - this may take some time Generating HLS segments for bitrate 36k - this may take some time All transcoding processes started, awaiting completion Encoding for bitrate 28k completed Encoding for bitrate k completed -- END SNIPPET -- Marked as trivial as there's no impact on the actual work being completed ----------------------------------------------------------------------------------------- Issue Relations ================ - Discovered In HLS-6: Adaptive Streams ----------------------------------------------------------------------------------------- Activity ========== ----------------------------------------------------------------------------------------- 2015-12-14 16:30:18 btasker ----------------------------------------------------------------------------------------- Looks like this is still an issue (and affected more than the last this time) -- BEGIN SNIPPET -- ffmpeg command found.... continuing Generating HLS segments for bitrate 512k - this may take some time Generating HLS segments for bitrate 1024k - this may take some time Generating HLS segments for bitrate 2048k - this may take some time All transcoding processes started, awaiting completion Encoding for bitrate 512k completed Encoding for bitrate k completed Encoding for bitrate k completed -- END SNIPPET -- ----------------------------------------------------------------------------------------- 2016-02-09 09:33:40 btasker ----------------------------------------------------------------------------------------- Came in as https://github.com/bentasker/HLS-Stream-Creator/issues/9 from user scotia70 -- BEGIN QUOTE -- Hi, great script. I've found a cosmetic issue, here's the output from a run. Note the bitrate number is missing from some of the the "encoding completed" lines. -- BEGIN SNIPPET -- #HLS-Stream-Creator.sh -i camera-01-20160209T101155.mp4 -s 10 -b 28,96,512,1600 ffmpeg command found.... continuing Generating HLS segments for bitrate 28k - this may take some time Generating HLS segments for bitrate 96k - this may take some time Generating HLS segments for bitrate 512k - this may take some time Generating HLS segments for bitrate 1600k - this may take some time All transcoding processes started, awaiting completion Encoding for bitrate (0) 28k completed Encoding for bitrate (0) k completed Encoding for bitrate (0) k completed Encoding for bitrate (0) k completed -- END SNIPPET -- I believe it's to do with the way the PIDS array is emptied. If you reverse the order of the bitrates (and hence they are likely to finish last to first, then the output is ok. Thanks -- END QUOTE -- Taking a quick scan over, I think the user is correct. Have asked them if they want to create a pull, otherwise will look at reversing the order myself ----------------------------------------------------------------------------------------- 2016-05-18 07:08:15 ----------------------------------------------------------------------------------------- btasker changed status from 'Open' to 'In Progress' ----------------------------------------------------------------------------------------- 2016-05-18 07:17:26 git ----------------------------------------------------------------------------------------- -- BEGIN QUOTE -- Repo: HLS-Stream-Creator Commit: 2711edfdc43678aa134523050a76690260f7f550 Author: B Tasker