##########################################################################################

       JILS-26: Commit links are being converted to hyperlinks twice

##########################################################################################


Issue Type: Bug 
-----------------------------------------------------------------------------------------

Issue Information
====================

Priority: Major					Status:      Closed
Resolution:  Fixed (2018-01-05 08:40:59)
Project: Jira Issue Listing Script (JILS)


Reported By: btasker					
Assigned To: btasker


Affected Versions:		
	- 0.1  			
	- 0.01b  			


Targeted for fix in version: 
	- 0.1


Time Estimate: 0 minutes
Time Logged:   0 minutes


-----------------------------------------------------------------------------------------

Issue Description
==================

Similar behaviour to JILS-19, but this time caused by JILS-25.

The hyperlink used within the commit notifications is being autolinked, and the commit
notification markup processing is then turning that into a link.

Needs a rounder solution, but the quick fix is to drop a negative lookback into the regex
to ensure it's not converted if the link is prefixed with a pipe symbol (|)

Something like


-- BEGIN SNIPPET --

(?<!\|)

 -- END SNIPPET --

Should do it, though will need testing

-----------------------------------------------------------------------------------------

Issue Relations
================
	
	- Caused by JILS-25: Automatically turn URLs into Hyperlinks


-----------------------------------------------------------------------------------------

Activity
==========

	
-----------------------------------------------------------------------------------------
2014-11-12 01:45:26              git
-----------------------------------------------------------------------------------------


-- BEGIN QUOTE --


Repo: Jira-Issue-Listing
Commit: 497efd9a0c4cd859266373d356b24d27a45a167b
Author: Ben Tasker <github@<Domain Hidden>>

Date: Wed Nov 12 01:44:23 2014 +0000
Commit Message: Updated autolinks to ignore commit links. See JILS-26



Modified (-)(+)
-------
utils.class.php



-- END QUOTE --

*Webhook User-Agent*


-- BEGIN SNIPPET --

GitHub-Hookshot/0687198
 -- END SNIPPET --

https://github.com/bentasker/Jira-Issue-Listing/commit/497efd9a0c4cd859266373d356b24d27a45a167b


	
-----------------------------------------------------------------------------------------
2014-11-12 01:47:06              btasker
-----------------------------------------------------------------------------------------

For the time being, have dropped a negative lookback into the regex


-- BEGIN SNIPPET --

((?<!\|)(http|ftp|https))

 -- END SNIPPET --

The problem with trying to keep the regular expressions simple is that we're going to hit
issues like this too regularly, but given the choice between unmaintainable regex and
occasionally breaking links, I think I prefer the latter.
	
-----------------------------------------------------------------------------------------
2014-11-12 01:47:22              
-----------------------------------------------------------------------------------------

btasker changed status from 'Open' to 'In Progress'
	
-----------------------------------------------------------------------------------------
2014-11-12 01:47:22              
-----------------------------------------------------------------------------------------

btasker added 'Ben Tasker' to assignee
	
-----------------------------------------------------------------------------------------
2016-04-24 18:27:04              
-----------------------------------------------------------------------------------------

btasker added '0.1' to Fix Version
	
-----------------------------------------------------------------------------------------
2016-04-29 15:18:19              
-----------------------------------------------------------------------------------------

btasker added '0.1' to Version
	
-----------------------------------------------------------------------------------------
2016-04-29 15:18:19              
-----------------------------------------------------------------------------------------

btasker added '0.01b' to Version
	
-----------------------------------------------------------------------------------------
2018-01-05 08:40:59              
-----------------------------------------------------------------------------------------

btasker changed status from 'In Progress' to 'Resolved'
	
-----------------------------------------------------------------------------------------
2018-01-05 08:40:59              
-----------------------------------------------------------------------------------------

btasker added 'Fixed' to resolution
	
-----------------------------------------------------------------------------------------
2018-01-05 08:41:02              
-----------------------------------------------------------------------------------------

btasker changed status from 'Resolved' to 'Closed'