##########################################################################################

       LOC-8: Exception will be thrown if a user uses the wrong key

##########################################################################################


Issue Type: Bug 
-----------------------------------------------------------------------------------------

Issue Information
====================

Priority: Major					Status:      Closed
Resolution:  Fixed (2018-05-13 09:39:46)
Project: LocalChat (LOC)


Reported By: btasker					
Assigned To: btasker

Components: 
	- Client 
	- Encryption 

Affected Versions:		
	- V0.0.2  			


Targeted for fix in version: 
	- V0.0.2


Time Estimate: 0 minutes
Time Logged:   0 minutes


-----------------------------------------------------------------------------------------

Issue Description
==================

If a user connects into a room using an incorrect room password (which is just used as the
key for the E2E encryption), then when they send a message all other users will get a
stack trace on their screens.

Need to adjust the client to make it handle this cleanly

-----------------------------------------------------------------------------------------

Activity
==========

	
-----------------------------------------------------------------------------------------
2018-05-13 09:39:46              
-----------------------------------------------------------------------------------------

btasker changed status from 'Open' to 'Resolved'
	
-----------------------------------------------------------------------------------------
2018-05-13 09:39:46              
-----------------------------------------------------------------------------------------

btasker added 'Fixed' to resolution
	
-----------------------------------------------------------------------------------------
2018-05-13 09:39:49              
-----------------------------------------------------------------------------------------

btasker changed status from 'Resolved' to 'Closed'
	
-----------------------------------------------------------------------------------------
2018-05-13 09:40:13              git
-----------------------------------------------------------------------------------------


-- BEGIN QUOTE --

Repo: LocalChat
Host:Rimmer

commit fd44f9a4b0c33ed4126ee198fb2783a10d8ac473
Author: B Tasker <github@<Domain Hidden>>
Date:   Sun May 13 09:37:31 2018 +0100

Commit Message: LOC-8 Do not throw exception if message cannot be decrypted
    
    If a user connects into a room using a different encryption key to everyone else, do
not let them effectively DoS the room by causing exceptions in everyone else's clients.
    
    If we receive a message that cannot be decrypted, we simply print a warning to that
effect and carry on.
    
    Because the sending user's name is in the encrypted payload, we can't ascertain who
sent it - but as soon as someone else replies, that sending user will also get an error
message.

 client/LocalChatClient.py |    8 +++++++-
 1 files changed, 7 insertions(+), 1 deletions(-)

-- END QUOTE --

https://repos.bentasker.co.uk/projects/LocalChat.git/commits/fd44f9a4b0c33ed4126ee198fb2783a10d8ac473
|
https://repos.bentasker.co.uk/projects/LocalChat.git/commitdiff/fd44f9a4b0c33ed4126ee198fb2783a10d8ac473