##########################################################################################
MCI-1: Issue with H3 Regex
##########################################################################################
Issue Type: Task
-----------------------------------------------------------------------------------------
Issue Information
====================
Priority: Major Status: Closed
Resolution: Fixed (2014-11-06 16:03:55)
Project: Mod Cat Implode (MCI)
Reported By: btasker
Assigned To: btasker
Time Estimate: 0 minutes
Time Logged: 0 minutes
-----------------------------------------------------------------------------------------
Issue Description
==================
There's an issue with the Regex used to detect H3's. The following text, for example, will
trigger it and lead to a broken layout
-- BEGIN QUOTE --
"timestamp":1382057808,
"response":[
"eJw9jMsOgjAQRb+GLslMI3H36EJ0485o+IAKAxINwRYT+HtREjZnce7jyUvfeBQxDI13BFp0PHhUJMFYAhLTMrK\/cUqC5ykGn9kyk\/J8WZGpw0rCHJXO0chc\/6Q8ruR57COnrbS9kQXawiu\/P5wmbsplf6lw31aJ4+7\/2p5EeHU+PQKK1Hde17YlBdYwILaG0dUuqDvIYArtQNtQ8Bq6L577OhI=",
1382058708
],
"errors":null,
"error":0
-- END QUOTE --
The H3 buried within the response eJw9jMsOgjAQRb+GLslMI3 *H3* 6EJ0485o+IAKAxINwRYT is
detected by the regex and the preceding characters up to the opening of the
are
treated as part of the tag.
-----------------------------------------------------------------------------------------
Activity
==========
-----------------------------------------------------------------------------------------
2013-10-21 22:14:28 btasker
-----------------------------------------------------------------------------------------
Was able to work around it on the affected page by simply changing the H3 to something
else (as it was only an example) but need a longer term solution
-----------------------------------------------------------------------------------------
2014-11-06 16:03:55
-----------------------------------------------------------------------------------------
btasker changed status from 'Open' to 'Resolved'
-----------------------------------------------------------------------------------------
2014-11-06 16:03:55
-----------------------------------------------------------------------------------------
btasker added 'Ben Tasker' to assignee
-----------------------------------------------------------------------------------------
2014-11-06 16:03:55
-----------------------------------------------------------------------------------------
btasker added 'Fixed' to resolution
-----------------------------------------------------------------------------------------
2014-11-06 16:03:58
-----------------------------------------------------------------------------------------
btasker changed status from 'Resolved' to 'Closed'
-----------------------------------------------------------------------------------------
2014-11-06 16:05:33 git
-----------------------------------------------------------------------------------------
-- BEGIN QUOTE --
Repo: mod_CatImplode
Host:Rimmer
commit fd20905e6b24b916d29c56eb18f4b57099fcf9eb
Author: Ben Tasker >
Date: Thu Nov 6 16:03:39 2014 +0000
Commit Message: Corrected wildcard used for H3's. See MCI-1
helper.php | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
-- END QUOTE --
https://repos.bentasker.co.uk/projects/mod_CatImplode.git/commits/fd20905e6b24b916d29c56eb18f4b57099fcf9eb
|
https://repos.bentasker.co.uk/projects/mod_CatImplode.git/commitdiff/fd20905e6b24b916d29c56eb18f4b57099fcf9eb