##########################################################################################

       VID-1: Minify Embed JS

##########################################################################################


Issue Type: Task 
-----------------------------------------------------------------------------------------

Issue Information
====================

Priority: Major					Status:      Closed
Resolution:  Done (2019-04-02 18:03:37)
Project: Videos.bentasker.co.uk (VID)


Reported By: btasker					
Assigned To: btasker



Targeted for fix in version: 
	- v0.13


Time Estimate: 0 minutes
Time Logged:   0 minutes


-----------------------------------------------------------------------------------------

Issue Description
==================

Currently the embed code isn't minified, so takes longer to load than it should (albeit
still minimal).

Should really create a minified copy, which can then be updated whenever a release is done

-----------------------------------------------------------------------------------------

Activity
==========

	
-----------------------------------------------------------------------------------------
2019-03-27 16:31:14              
-----------------------------------------------------------------------------------------

btasker added 'VNEXT' to Fix Version
	
-----------------------------------------------------------------------------------------
2019-03-27 16:31:14              
-----------------------------------------------------------------------------------------

btasker removed 'v0.12' from Fix Version
	
-----------------------------------------------------------------------------------------
2019-04-02 17:52:21              git
-----------------------------------------------------------------------------------------


-- BEGIN QUOTE --

Repo: videos.bentasker.co.uk
Host:Rimmer

commit e7c5148652d4093e3b13fbc4f12ced798cb26938
Author: B Tasker <github@<Domain Hidden>>
Date:   Tue Apr 2 17:50:48 2019 +0100

Commit Message: VID-1 Add Test page to allow minified vnext JS to be tested
    
    This has also been assigned a reduced TTL on the CDN to aid development

 resources/tests/Player_VNext_min.html |   34 +++++++++++++++++++++++++++++++++
 1 files changed, 34 insertions(+), 0 deletions(-)

-- END QUOTE --

https://repos.bentasker.co.uk/projects/videos.bentasker.co.uk.git/commits/e7c5148652d4093e3b13fbc4f12ced798cb26938
|
https://repos.bentasker.co.uk/projects/videos.bentasker.co.uk.git/commitdiff/e7c5148652d4093e3b13fbc4f12ced798cb26938

	
-----------------------------------------------------------------------------------------
2019-04-02 18:00:21              git
-----------------------------------------------------------------------------------------


-- BEGIN QUOTE --

Repo: videos.bentasker.co.uk
Host:Rimmer

commit 93bdfa21b68f3102849fa59740897d1b9f19a4cb
Author: B Tasker <github@<Domain Hidden>>
Date:   Tue Apr 2 17:55:08 2019 +0100

Commit Message: VID-1 Minify the embed code
    
    Added a minified version of embed.js as embed.min.js
    
    Generated with the following
    
-- BEGIN SNIPPET --

cat copyright.txt > embed.min.js; uglifyjs embed.js > embed.min.js
    
 -- END SNIPPET --
    
    All embed calls should now really always point at the minified code

 resources/embed/copyright.txt |    9 +++++++++
 resources/embed/embed.min.js  |    1 +
 2 files changed, 10 insertions(+), 0 deletions(-)
-- END QUOTE --

https://repos.bentasker.co.uk/projects/videos.bentasker.co.uk.git/commits/93bdfa21b68f3102849fa59740897d1b9f19a4cb
|
https://repos.bentasker.co.uk/projects/videos.bentasker.co.uk.git/commitdiff/93bdfa21b68f3102849fa59740897d1b9f19a4cb

	
-----------------------------------------------------------------------------------------
2019-04-02 18:00:21              git
-----------------------------------------------------------------------------------------


-- BEGIN QUOTE --

Repo: videos.bentasker.co.uk
Host:Rimmer

commit 92ac62a95d9d0710459aa1cff591997e18fdd258
Author: B Tasker <github@<Domain Hidden>>
Date:   Tue Apr 2 17:58:23 2019 +0100

Commit Message: VID-1 Update Player and README to refer to minified version of the JS

 Player.html |    2 +-
 README.md   |    4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

-- END QUOTE --

https://repos.bentasker.co.uk/projects/videos.bentasker.co.uk.git/commits/92ac62a95d9d0710459aa1cff591997e18fdd258
|
https://repos.bentasker.co.uk/projects/videos.bentasker.co.uk.git/commitdiff/92ac62a95d9d0710459aa1cff591997e18fdd258

	
-----------------------------------------------------------------------------------------
2019-04-02 18:00:21              git
-----------------------------------------------------------------------------------------


-- BEGIN QUOTE --

Repo: videos.bentasker.co.uk
Host:Rimmer

commit f11437489de9148c44f2c93937f3b680678b2ddd
Author: B Tasker <github@<Domain Hidden>>
Date:   Tue Apr 2 17:59:15 2019 +0100

Commit Message: VID-1 One job.... command should have been
    
-- BEGIN SNIPPET --

cat copyright.txt > embed.min.js; uglifyjs embed.js >> embed.min.js
    
 -- END SNIPPET --

 resources/embed/embed.min.js |    9 +++++++++
 1 files changed, 9 insertions(+), 0 deletions(-)

-- END QUOTE --

https://repos.bentasker.co.uk/projects/videos.bentasker.co.uk.git/commits/f11437489de9148c44f2c93937f3b680678b2ddd
|
https://repos.bentasker.co.uk/projects/videos.bentasker.co.uk.git/commitdiff/f11437489de9148c44f2c93937f3b680678b2ddd

	
-----------------------------------------------------------------------------------------
2019-04-02 18:03:37              
-----------------------------------------------------------------------------------------

btasker changed status from 'Open' to 'Resolved'
	
-----------------------------------------------------------------------------------------
2019-04-02 18:03:37              
-----------------------------------------------------------------------------------------

btasker added 'Done' to resolution
	
-----------------------------------------------------------------------------------------
2019-04-02 18:03:41              
-----------------------------------------------------------------------------------------

btasker changed status from 'Resolved' to 'Closed'
	
-----------------------------------------------------------------------------------------
2019-04-02 18:13:49              btasker
-----------------------------------------------------------------------------------------

Just for comparison, the current size difference is

-- BEGIN SNIPPET --

ben@milleniumfalcon:~/Documents/src.old/videos.bentasker.co.uk/resources/embed$ stat -c %s
embed.js 
6970
ben@milleniumfalcon:~/Documents/src.old/videos.bentasker.co.uk/resources/embed$ stat -c %s
embed.min.js 
4669

 -- END SNIPPET --