utilities/auto-blog-link-preserver#19: Failure count stat can be higher than link count



Issue Information

Issue Type: issue
Status: closed
Reported By: btasker
Assigned To: btasker

Milestone: vnext
Created: 12-Aug-24 07:39



Description

In stats output to InfluxDB, the reported failure and duplicate counts can be higher than the reported number of total links seen.

This is as a result of the code-shift around done for #10

Submission is handled separately for URLs referenced within the source RSS feed itself, but the link counter is not incremented:

# Submit the link itself to linkwarden
page_status = submit_to_linkwarden(entry.link, tags)
# TODO: DRY this up
if page_status == 0:
    failure_count += 1
elif page_status == 2:
    duplicate_count += 1    

So any recorded failure or duplication will not be mirrored by a count in the overall total



Toggle State Changes

Activity


assigned to @btasker

verified

mentioned in commit 0b5540046fc7d82bcfbc787c974f852a4d9ad24b

Commit: 0b5540046fc7d82bcfbc787c974f852a4d9ad24b 
Author: B Tasker                            
                            
Date: 2024-08-12T08:39:25.000+01:00 

Message

fix: add missing count increment (utilities/auto-blog-link-preserver#19)

+1 -0 (1 lines changed)