project Websites / Gitlab Issue Listing Script avatar

websites/Gitlab-Issue-Listing-Script#34: Add config toggle for "View in Gitlab" links

Issue Information

Issue Type: issue
Status: closed
Reported By: btasker
Assigned To: btasker

Milestone: v0.4
Created: 22-Apr-22 22:44



Description

Most templates have a link out to Gitlab for whichever page the user is currently viewing.

That's not something we really want in a public mirror, so we should add a config toggle to enable/disable them



Toggle State Changes

Activity


22-Apr-22 22:44

assigned to @btasker


22-Apr-22 22:45

I'm actually mildly tempted to say we should remove them rather than add a toggle.

But, they do have a use: I already find it's easier to view/read an issue on my phone in GILS, but if I want to comment on it I need to go to GL, and the link's a helpful way to just hop across.


22-Apr-22 22:58
verified

mentioned in commit 18da9356edc6c755cd4054ea47378dc64536dbd2

Commit: 18da9356edc6c755cd4054ea47378dc64536dbd2 
Author: B Tasker                            
                            
Date: 2022-04-22T23:58:07.000+01:00

Message

Add config toggle to disable "View in Gitlab links" for websites/Gitlab-Issue-Listing-Script#34

This commit

  • Adds a new GILSUtils method getTemplateConfig()
  • Makes a new variable $template_vars available to all templates
  • Adds a new config option $display_gitlab_links
  • Adjusts the templates to check whether this is enabled before embedding links back to the source Gitlab install
+66 -22 (88 lines changed)