project Websites / Gitlab Issue Listing Script avatar

websites/Gitlab-Issue-Listing-Script#36: Review Issues table format



Issue Information

Issue Type: issue
Status: closed
Reported By: btasker

Milestone: v0.5
Created: 22-Apr-22 23:14



Description

The issues table (displayed on project indexes, milestone pages etc) is still in the format that JILS used

ID, Type, Title, Status, Created, Assigned To

But, some of these don't really make sense in Gitlab land.

The vast majority of items will be Type Issue because the only other option (by default) is Incident.

If we want to be able to discern what type of issue something is, we probably need to include it's tags in the table.



Toggle State Changes

Activity


verified

mentioned in commit 71caec5d6ae1cc08d8b4e6fc03c907a72a2dfe3f

Commit: 71caec5d6ae1cc08d8b4e6fc03c907a72a2dfe3f 
Author: B Tasker                            
                            
Date: 2022-08-26T18:10:34.000+01:00 

Message

Remove issue type and assignee from the issues table for websites/Gitlab-Issue-Listing-Script#36

This is the start of a review of it's layout

+1 -3 (4 lines changed)

Whilst it'd be nice to display an issue's labels within the table, doing so isn't straightforward.

Gitlab's API returns a list of the associated label names, but doesn't include their IDs, so there isn't a way to link them directly with the CSS we generate.

On a project index page, we retrieve the labels separately (so that we can print the labels section), but that's not the only place we use the table.

We could add a lookup though, with a conditional to make sure we safely handle uses where the label listing isn't available.

That would at least us test the idea of displaying labels quickly.

verified

mentioned in commit 2801c592d9b6c2b38625b1d2a1ad6ee3b238212f

Commit: 2801c592d9b6c2b38625b1d2a1ad6ee3b238212f 
Author: B Tasker                            
                            
Date: 2022-08-27T14:13:20.000+01:00 

Message

The issue listing table now supports label display (websites/Gitlab-Issue-Listing-Script#36)

If the variable $labels is set, the table will attempt to display label lozenges alongside issues.

The variable labels can be populated in the correct format by calling $this->getProjectLabels($proj_path)

Label CSS must also have been rendered into the page - building that is currently handled by individual model functions which rely on it, should look at making it DRY in future

+32 -2 (34 lines changed)
verified

mentioned in commit b169cafa7bb1666051b6598b771cd81bb1ef0297

Commit: b169cafa7bb1666051b6598b771cd81bb1ef0297 
Author: B Tasker                            
                            
Date: 2022-08-27T14:16:35.000+01:00 

Message

Don't centre the issue listing table websites/Gitlab-Issue-Listing-Script#36

+2 -1 (3 lines changed)

I think we're generally looking much better

Old Screenshot_20220827_141733

New Screenshot_20220827_141705

I think Created needs to stay, though we should reformat the time.

verified

mentioned in commit 5a015b96d0da5ee7cfd2ef63928b8248fd2fc984

Commit: 5a015b96d0da5ee7cfd2ef63928b8248fd2fc984 
Author: B Tasker                            
                            
Date: 2022-08-27T14:21:15.000+01:00 

Message

Switch issue table date from RFC 3339 to d M y (websites/Gitlab-Issue-Listing-Script#36)

+5 -1 (6 lines changed)
verified

mentioned in commit 35b967a852dd8a353f1308d1dbd815a3eaf7db85

Commit: 35b967a852dd8a353f1308d1dbd815a3eaf7db85 
Author: B Tasker                            
                            
Date: 2022-08-27T14:23:35.000+01:00 

Message

Fix table filtering on issue listing table (websites/Gitlab-Issue-Listing-Script#36)

Columns:

  • 0: Issue Key, select
  • 1: Issue title, freetext search
  • 2: Issue status, select
  • 3: Creation date: select
+1 -3 (4 lines changed)
verified

mentioned in commit 9dd04e4aaaaa5d61101fb8101470ce42cfd6b268

Commit: 9dd04e4aaaaa5d61101fb8101470ce42cfd6b268 
Author: B Tasker                            
                            
Date: 2022-08-27T14:30:41.000+01:00 

Message

Display labels in issues-table in milestone view (websites/Gitlab-Issue-Listing-Script#36)

+14 -2 (16 lines changed)

Because the labels are included as part of the title, you can search by label by typing it's text (or part of it) into the search box

Screenshot_20220827_143214