project Websites / Privacy Sensitive Analytics avatar

websites/privacy-sensitive-analytics#15: Bad Domains reporting should handle file:// scheme



Issue Information

Issue Type: issue
Status: closed
Reported By: btasker
Assigned To: btasker

Milestone: V0.3
Created: 02-Apr-22 07:59



Description

In websites/privacy-sensitive-analytics#10 we added reporting of bad domains.

I've been working on an article this week, and to help drafting have been running a local copy of my site - I've been accessing the page I'm working on via a file:// URL.

That's correctly triggered the bad domain reporting, but no domain gets reported (because there isn't one), leading to a pretty weird looking entry in the reporting dashboards.

The agent should check the scheme, if it's file: then we should override the domain with something indicating that (I guess arguably, we should be recording scheme rather than assuming everything's HTTPS too).



Issue Links

Toggle State Changes

Activity


assigned to @btasker

marked this issue as related to #10

verified

mentioned in commit f6cc9524d90d79313191e5790b529d64442d7b66

Commit: f6cc9524d90d79313191e5790b529d64442d7b66 
Author: B Tasker                            
                            
Date: 2022-04-02T23:19:40.000+01:00 

Message

Update enhanced gather to handle protocols/schemes that don't involve a domain name. See websites/privacy-sensitive-analytics#15

+7 -0 (7 lines changed)
verified

mentioned in commit c3c69d4c82bb9c63a7e79971419c548e2af83f40

Commit: c3c69d4c82bb9c63a7e79971419c548e2af83f40 
Author: B Tasker                            
                            
Date: 2022-04-02T23:22:35.000+01:00 

Message

Capture protocol information as suggested in websites/privacy-sensitive-analytics#15

+9 -0 (9 lines changed)