GPXIN-31: Notices on Import

Issue Type: Bug

Priority: Major

Status: Closed

Reported By:

Ben Tasker

Assigned To:

Ben Tasker

Project: PHP GPXIngest (GPXIN)

Resolution: Fixed (2017-07-03 09:27:52)

Affects Version: 1.02, 1.03,

Target version: 1.03,

Created: 2017-07-02 12:17:50

Time Spent Working

Estimated:

15 minutes

Remaining:

0 minutes

Logged:

15 minutes

Include Subtasks

Description

GPXIN-27 added support for routes, however because the class isn't created by default it generates a PHP WARNING level error/warning.

Need to adjust to ensure that journey->related->routes is defined by default.

Toggle State Changes

Activity

Ben Tasker
Permalink
2017-07-02 12:18:15

Originally raised in Github #19

Git Commit Handler
Permalink
2017-07-03 09:25:30

Repo: PHP-GPX-Ingest
Commit: 68b717f63e90542808953633c85c98e34a527032
Author: B Tasker <github@<Domain Hidden>>

Date: Mon Jul 03 09:17:39 2017 +0100
Commit Message: GPXIN-31 Ensure journey->related->routes is initialised correctly (from #19) to prevent WARNING level entries

Test case is fairly simple:
    <?php

    error_reporting(E_ALL);
    ini_set('display_errors','On');

    require 'src/GPXIngest/GPXIngest.php';

    $gpx = new GPXIngest\GPXIngest;
    $gpx->loadFile('gpx-ingest-pb.gpx');
Where gpx-ingest-pb is a GPX file that makes use of rte points (see #19 for an example)

Modified (-)(+)
-------
src/GPXIngest/GPXIngest.php

Webhook User-Agent

GitHub-Hookshot/18889e1

View Commit

Ben Tasker
Permalink
2017-07-03 09:27:29

Marking this as resolved, test case passes and it was always going to be a simple fix anyway.

Unassigned
Permalink
2017-07-03 09:27:39

btasker changed timespent from '0 minutes' to '15 minutes'

Unassigned
Permalink
2017-07-03 09:27:53

btasker changed status from 'Open' to 'Resolved'

Unassigned
Permalink
2017-07-03 09:27:53

btasker added 'Fixed' to resolution

Unassigned
Permalink
2017-07-03 09:28:16

btasker changed status from 'Resolved' to 'Closed'

GPXIN-31: Notices on Import

Issue Information

Issue Links

Activity

Work log

Caused by		~~GPXIN-27:~~ Route Support
		Github #19