JWL-7: Empty emails being received

Issue Information

Issue Type: Bug
 
Priority: Major
Status: Closed

Reported By:
Ben Tasker
Assigned To:
Ben Tasker
Project: Jira Webhook Listener (JWL)
Resolution: Fixed (2014-12-23 00:14:32)
Components: Email Action ,

Created: 2014-12-23 00:12:45
Time Spent Working


Description
Emails without a subject or body are being received from the Webhook listener - it looks like it may be triggering for a variety of actions.

Hadn't noticed in earlier testing as Google mail had rather helpfully classed them as Spam.


Toggle State Changes

Activity


2014-12-23 00:14:10

Repo: Jira-Webhook-Listener
Commit: c9c4aece42a166aeb315b5e9227c43a607bd52f7
Author: Ben Tasker <github@<Domain Hidden>>

Date: Tue Dec 23 00:12:50 2014 +0000
Commit Message: Prevented sending of empty emails on unrecognised events. See JWL-7



Modified (-)(+)
-------
actions/email.action.php




Webhook User-Agent 

GitHub-Hookshot/2f00e0f


View Commit


2014-12-23 00:14:23
It appears I hadn't included a default action within the email action's switch statement. Have now included one (return)

2014-12-23 00:14:32
btasker changed status from 'Open' to 'Resolved'

2014-12-23 00:14:32
btasker added 'Fixed' to resolution

2014-12-23 00:14:38
btasker changed status from 'Resolved' to 'Closed'