MISC-9: Analytics/Social Icons show as enabled when Javascript is disabled



Issue Information

Issue Type: Bug
 
Priority: Major
Status: Closed

Reported By:
Ben Tasker
Assigned To:
Ben Tasker
Project: Miscellaneous (MISC)
Resolution: Fixed (2015-05-22 19:30:25)
Affects Version: Bentasker.co.uk via Tor,
Target version: Bentasker.co.uk via Tor,

Created: 2015-05-22 19:20:00
Time Spent Working


Description
Although they're obviously not triggering (because JS is disabled) the Privacy bar on the left shows 'Enable Social Icons' and 'Enable Google Analytics' if Javascript isn't enabled.

It's a minor thing, but probably worth changing the default text to represent the default behaviour (or better remove the default text so that the bar only appears if JS is enabled).


Issue Links

Toggle State Changes

Activity


Original block in template
<h4>Privacy Options</h4>

</div>
<div class="tmplateOptions">
       	<a rel="nofollow" onclick="togglesocialIcons();" id='socialBlock'>Block Social Icons</a>
</div>
<div class="tmplateOptions hidden-phone">
       	<a rel="nofollow" onclick="toggleGA();" id='GABlock'>Block Google Analytics</a>
</div>

<?php if (!$via_tor): ?>
       	<div class="tmplateOptions hidden-phone">
                <a rel="nofollow" href="<?php echo $onion_addr; ?>" id='OnionLink'>Browse via Tor</a>
        </div>
<?php endif; ?>

Updated to
<h4 id='privOpts'>Privacy Options</h4>
<div class="tmplateOptions">
       	<a rel="nofollow" onclick="togglesocialIcons();" id='socialBlock'></a>
</div>
<div class="tmplateOptions hidden-phone">
       	<a rel="nofollow" onclick="toggleGA();" id='GABlock'></a>
</div>

<?php if (!$via_tor): ?>
       	<div class="tmplateOptions hidden-phone">
                <a rel="nofollow" href="<?php echo $onion_addr; ?>" id='OnionLink'>Browse via Tor</a>
        </div>
<?php endif; ?>

Re-tested with Orbot and the privacy bar no longer appears (which is fine as it requires Javascript to work).
btasker changed status from 'Open' to 'Resolved'
btasker added 'Fixed' to resolution
btasker changed status from 'Resolved' to 'Closed'
Note: Works fine in Lightning browser