PHPCRED-25: Keylength calculation incorrect

Issue Information

Issue Type: Task
 
Priority: Major
Status: Resolved

Reported By:
Ben Tasker
Assigned To:
Ben Tasker
Project: PHPCredlocker (PHPCRED)
Resolution: Done (2014-07-25 02:31:49)
Affects Version: 1.15, 1.5, 1.25,
Target version: 1.25,
Components: Crypto ,

Created: 2014-07-25 01:20:45
Time Spent Working


Description
The keylength calculation made in Crypto::xorestring(), Crypto::xordstring(), xorestr(), xordstr() is incorrect.

The length needs to be calculated against one of the segments as the current calculation allows the crypto to fall off the end of the key (resulting either in errors, or values of 0 being used in the Xor - depending on the implementation).

Issue was identified and fixed in the BTFW fork ( BTFW-7 )


Toggle State Changes

Activity


2014-07-25 02:31:40
Resolved by commit 4ca4abd

2014-07-25 02:31:49
btasker changed status from 'Open' to 'Resolved'

2014-07-25 02:31:49
btasker added 'Done' to resolution