VID-4: Support multiple players on the same page

Issue Type: New Feature

Priority: Major

Status: Closed

Reported By:

Ben Tasker

Assigned To:

Ben Tasker

Project: Videos.bentasker.co.uk (VID)

Resolution: Done (2019-03-27 16:30:23)

Target version: v0.12,

Components: Embed Code ,

Created: 2019-03-27 13:20:55

Time Spent Working

Include Subtasks

Description

At some point, it's almost a given that I'm going to want to embed multiple videos in the same page (perhaps parts of a walkthrough).

Currently that isn't possible as the DOM Id video is hardcoded into the embed script.

Should update so that an ID is autocalculated if the default already exists. Probably wise to change the default from video to something less likely to collide with the original page too.

Toggle State Changes

Activity

Ben Tasker
Permalink
2019-03-27 13:45:32

This is implemented. The video will now be embedded with id BensVideon where n is an incrementing integer.

Git Commit Handler
Permalink
2019-03-27 13:46:21

Repo: videos.bentasker.co.uk
Host:Rimmer

commit b04a57e1ea5e4ddbe23b7887016a5b88af72e4c4
Author: B Tasker <github@<Domain Hidden>>
Date: Wed Mar 27 13:43:39 2019 +0000

Commit Message: VID-4 enable support for embedding multiple players into the same page

resources/embed/embed.js | 48 ++++++++++++++++----------
resources/tests/vid_4_multi_embed_test.html | 24 +++++++++++++
2 files changed, 53 insertions(+), 19 deletions(-)

View Commit | View Changes

Unassigned
Permalink
2019-03-27 16:30:23

btasker changed status from 'Open' to 'Resolved'

Unassigned
Permalink
2019-03-27 16:30:23

btasker added 'Done' to resolution

Unassigned
Permalink
2019-03-27 16:30:27

btasker changed status from 'Resolved' to 'Closed'

VID-4: Support multiple players on the same page

Issue Information

Activity