ADBLK-20: Split manualblock into multiple config files

Issue Information

Issue Type: New Feature
 
Priority: Major
Status: Closed

Reported By:
Ben Tasker
Assigned To:
Ben Tasker
Project: Adblock Lists (ADBLK)
Resolution: Done (2020-05-02 11:11:46)

Created: 2020-05-02 10:28:35
Time Spent Working


Description
At the moment, domains are blocked by adding them to manualblock.txt

But, there are scores and scores of domains in there that are related to one company (for example - Admiral Anti-Adblock).

It'd probably be better to having manualblock be a directory, with the builder just reading in any files that are in there


Toggle State Changes

Activity


2020-05-02 10:44:15

Repo: adblocklists
Commit: c95c79646ff98e2165a7f8bd07ef4336b370c4c3
Author: B Tasker <github@<Domain Hidden>>

Date: Sat May 02 10:42:04 2020 +0100
Commit Message: ADBLK-20 Split manualblocks out into seperate files so that individual companies can be spotted/updated easily



Added (+)
-------
config/manualblocks/00_general.txt
config/manualblocks/admiral-antiadblock.txt
config/manualblocks/xiaomi.txt


Modified (-)(+)
-------
bin/update_addomains.sh




Webhook User-Agent 

GitHub-Hookshot/7431eee


View Commit


2020-05-02 10:45:10
I've preserved the old manualblock.txt within the repo (under defunct as of this commit - https://github.com/bentasker/adblocklists/commit/c06c72d8287fb9a09f74575a8111d97a20f85602) so that git blame can still be used on it to see when/why a domain was added.

2020-05-02 10:52:16

Repo: adblocklists
Commit: e3c32496ee245b5fa84f414d7a9e6f001964b551
Author: B Tasker <github@<Domain Hidden>>

Date: Sat May 02 10:46:33 2020 +0100
Commit Message: ADBLK-20 Remove errant semicolon and add a `do`



Modified (-)(+)
-------
bin/update_addomains.sh




Webhook User-Agent 

GitHub-Hookshot/7431eee


View Commit


2020-05-02 10:52:17

Repo: adblocklists
Commit: fecf3ce63210b9f1a918e2a238e612c63dbcb02c
Author: B Tasker <github@<Domain Hidden>>

Date: Sat May 02 10:50:34 2020 +0100
Commit Message: ADBLK-20 Update build_abp to use the new block files



Modified (-)(+)
-------
bin/build_abp.sh




Webhook User-Agent 

GitHub-Hookshot/7431eee


View Commit


2020-05-02 11:11:46
btasker changed status from 'Open' to 'Resolved'

2020-05-02 11:11:46
btasker added 'Done' to resolution

2020-05-02 11:11:49
btasker changed status from 'Resolved' to 'Closed'