LOC-8: Exception will be thrown if a user uses the wrong key

Issue Information

Issue Type: Bug
 
Priority: Major
Status: Closed

Reported By:
Ben Tasker
Assigned To:
Ben Tasker
Project: LocalChat (LOC)
Resolution: Fixed (2018-05-13 09:39:46)
Affects Version: V0.0.2,
Target version: V0.0.2,
Components: Client , Encryption ,

Created: 2018-05-13 09:33:29
Time Spent Working


Description
If a user connects into a room using an incorrect room password (which is just used as the key for the E2E encryption), then when they send a message all other users will get a stack trace on their screens.

Need to adjust the client to make it handle this cleanly


Toggle State Changes

Activity


2018-05-13 09:39:46
btasker changed status from 'Open' to 'Resolved'

2018-05-13 09:39:46
btasker added 'Fixed' to resolution

2018-05-13 09:39:49
btasker changed status from 'Resolved' to 'Closed'

2018-05-13 09:40:13
Repo: LocalChat
Host:Rimmer

commit fd44f9a4b0c33ed4126ee198fb2783a10d8ac473
Author: B Tasker <github@<Domain Hidden>>
Date: Sun May 13 09:37:31 2018 +0100

Commit Message: LOC-8 Do not throw exception if message cannot be decrypted

If a user connects into a room using a different encryption key to everyone else, do not let them effectively DoS the room by causing exceptions in everyone else's clients.

If we receive a message that cannot be decrypted, we simply print a warning to that effect and carry on.

Because the sending user's name is in the encrypted payload, we can't ascertain who sent it - but as soon as someone else replies, that sending user will also get an error message.

client/LocalChatClient.py | 8 +++++++-
1 files changed, 7 insertions(+), 1 deletions(-)


View Commit | View Changes