VID-1: Minify Embed JS



Issue Information

Issue Type: Task
 
Priority: Major
Status: Closed

Reported By:
Ben Tasker
Assigned To:
Ben Tasker
Project: Videos.bentasker.co.uk (VID)
Resolution: Done (2019-04-02 18:03:37)
Target version: v0.13,

Created: 2019-03-27 12:31:26
Time Spent Working


Description
Currently the embed code isn't minified, so takes longer to load than it should (albeit still minimal).

Should really create a minified copy, which can then be updated whenever a release is done


Toggle State Changes

Activity


btasker added 'VNEXT' to Fix Version
btasker removed 'v0.12' from Fix Version
Repo: videos.bentasker.co.uk
Host:Rimmer

commit e7c5148652d4093e3b13fbc4f12ced798cb26938
Author: B Tasker <github@<Domain Hidden>>
Date: Tue Apr 2 17:50:48 2019 +0100

Commit Message: VID-1 Add Test page to allow minified vnext JS to be tested

This has also been assigned a reduced TTL on the CDN to aid development

resources/tests/Player_VNext_min.html | 34 +++++++++++++++++++++++++++++++++
1 files changed, 34 insertions(+), 0 deletions(-)


View Commit | View Changes
Repo: videos.bentasker.co.uk
Host:Rimmer

commit 93bdfa21b68f3102849fa59740897d1b9f19a4cb
Author: B Tasker <github@<Domain Hidden>>
Date: Tue Apr 2 17:55:08 2019 +0100

Commit Message: VID-1 Minify the embed code

Added a minified version of embed.js as embed.min.js

Generated with the following
cat copyright.txt > embed.min.js; uglifyjs embed.js > embed.min.js
    


All embed calls should now really always point at the minified code

resources/embed/copyright.txt | 9 +++++++++
resources/embed/embed.min.js | 1 +
2 files changed, 10 insertions(+), 0 deletions(-)


View Commit | View Changes
Repo: videos.bentasker.co.uk
Host:Rimmer

commit 92ac62a95d9d0710459aa1cff591997e18fdd258
Author: B Tasker <github@<Domain Hidden>>
Date: Tue Apr 2 17:58:23 2019 +0100

Commit Message: VID-1 Update Player and README to refer to minified version of the JS

Player.html | 2 +-
README.md | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)


View Commit | View Changes
Repo: videos.bentasker.co.uk
Host:Rimmer

commit f11437489de9148c44f2c93937f3b680678b2ddd
Author: B Tasker <github@<Domain Hidden>>
Date: Tue Apr 2 17:59:15 2019 +0100

Commit Message: VID-1 One job.... command should have been
cat copyright.txt > embed.min.js; uglifyjs embed.js >> embed.min.js
    


resources/embed/embed.min.js | 9 +++++++++
1 files changed, 9 insertions(+), 0 deletions(-)


View Commit | View Changes
btasker changed status from 'Open' to 'Resolved'
btasker added 'Done' to resolution
btasker changed status from 'Resolved' to 'Closed'
Just for comparison, the current size difference is
ben@milleniumfalcon:~/Documents/src.old/videos.bentasker.co.uk/resources/embed$ stat -c %s embed.js 
6970
ben@milleniumfalcon:~/Documents/src.old/videos.bentasker.co.uk/resources/embed$ stat -c %s embed.min.js 
4669