VID-2: Minify HLS plugin code

Issue Information

Issue Type: Task
 
Priority: Major
Status: Closed

Reported By:
Ben Tasker
Assigned To:
Ben Tasker
Project: Videos.bentasker.co.uk (VID)
Resolution: Done (2019-03-27 12:45:35)
Target version: v0.12,
Components: Resources ,

Created: 2019-03-27 12:34:02
Time Spent Working


Description
Need to create a minified version of resources/js/videojs-contrib-hls.js.

Although resources/js/videojs-contrib-hls.min.js currently exists, it should not be used as it doesn't contain a manually patched bugfix that was made (forcing it to remember 302's - see OS-25 for details).

Should therefore remove the original minified file (to ensure it doesn't accidentally get used) and then created a minified version of the patched code


Toggle State Changes

Activity


2019-03-27 12:36:21
Repo: videos.bentasker.co.uk
Host:Rimmer

commit 8d20806ed8ec11f8430ad49ba2351ad638e13e74
Author: B Tasker <github@<Domain Hidden>>
Date: Wed Mar 27 12:34:12 2019 +0000

Commit Message: VID-2 Remove existing minified HLS plugin code

It's not actually a minified version of the non-minified code as a manual patch was made to fix a bug

resources/js/videojs-contrib-hls.min.js | 8 --------
1 files changed, 0 insertions(+), 8 deletions(-)


View Commit | View Changes

2019-03-27 12:44:19
Done: 
sudo apt-get install node-uglify
uglifyjs videojs-contrib-hls.js > videojs-contrib-hls.min.js


Size difference isn't that far off 50% 
692K videojs-contrib-hls.js  348K videojs-contrib-hls.min.js

2019-03-27 12:45:35
btasker changed status from 'Open' to 'Resolved'

2019-03-27 12:45:35
btasker added 'Ben Tasker' to assignee

2019-03-27 12:45:35
btasker added 'Done' to resolution

2019-03-27 12:46:19
btasker changed status from 'Resolved' to 'Closed'

2019-03-27 12:46:20
Repo: videos.bentasker.co.uk
Host:Rimmer

commit b4b47dddc4aaff1639e21314ebe6250f8d91faae
Author: B Tasker <github@<Domain Hidden>>
Date: Wed Mar 27 12:43:49 2019 +0000

Commit Message: VID-2 Minify HLS Plugin code

resources/js/videojs-contrib-hls.min.js | 12 ++++++++++++
1 files changed, 12 insertions(+), 0 deletions(-)


View Commit | View Changes